[webkit-reviews] review denied: [Bug 101047] REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing : [Attachment 208914] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 101047: REGRESSION (r132516): Javascript menu text incorrectly disappearing
and reappearing
https://bugs.webkit.org/show_bug.cgi?id=101047

Attachment 208914: Patch
https://bugs.webkit.org/attachment.cgi?id=208914&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208914&action=review


> Source/WebCore/rendering/RenderLayer.cpp:1186
> +		   RenderLayerCompositor* compositor = child->compositor();

All RenderLayers in the same document share the same RenderLayerCompositor. You
could fetch this once at the top of the function.

> Source/WebCore/rendering/RenderLayer.cpp:1188
> +		       compositor->setCompositingLayersNeedRebuild();

Would be nice to do this incrementally if we can.

> Source/WebCore/rendering/RenderLayer.h:1058
> +    void updateDescendantClippingContext(bool);

Unclear what the bool means here.

> LayoutTests/ChangeLog:22
> +	   *
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants
-expected.html: Added.
> +	   *
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants
.html: Added.
> +	   *
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants
2-expected.html: Added.
> +	   *
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants
2.html: Added.

I think text-output tests using layerTreeAsText() might be a better way to test
this.