[webkit-reviews] review denied: [Bug 119487] [Gtk] Cancel authentication on load failed : [Attachment 209098] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Anton Obzhirov
<a.obzhirov at samsung.com>'s request for review:
Bug 119487: [Gtk] Cancel authentication on load failed
https://bugs.webkit.org/show_bug.cgi?id=119487

Attachment 209098: Patch
https://bugs.webkit.org/attachment.cgi?id=209098&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209098&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:99
> +    g_signal_connect(webView, "load-failed", G_CALLBACK(pageLoadFailed),
authDialog);

You aren't disconnecting form the signal at all in the case that dialog is
destroyed.

> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.h:52
> +GtkWidget* webkitAuthenticationDialogNew(WebKitAuthenticationRequest*,
CredentialStorageMode, WebKitWebView* webView);

You don't need the argument name here.