[webkit-reviews] review granted: [Bug 120009] [GTK] Stop button should be added to MiniBrowser : [Attachment 209092] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Anton Obzhirov
<a.obzhirov at samsung.com>'s request for review:
Bug 120009: [GTK] Stop button should be added to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=120009

Attachment 209092: Patch
https://bugs.webkit.org/attachment.cgi?id=209092&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209092&action=review


> Tools/MiniBrowser/gtk/BrowserWindow.c:589
>      item = gtk_tool_button_new_from_stock(GTK_STOCK_REFRESH);
> -    g_signal_connect_swapped(item, "clicked", G_CALLBACK(reloadCallback),
window);
> +    g_signal_connect_swapped(item, "clicked",
G_CALLBACK(reloadOrStopCallback), window);
>      gtk_toolbar_insert(GTK_TOOLBAR(toolbar), item, -1);
>      gtk_widget_add_accelerator(GTK_WIDGET(item), "clicked", accelGroup,
GDK_KEY_F5, 0, GTK_ACCEL_VISIBLE);
>      gtk_widget_show(GTK_WIDGET(item));
> +    reloadOrStopButton = item;

Probably better just to use reloadOrStopButton instead of item here.