[webkit-reviews] review granted: [Bug 119995] Start removing custom implementations of getOwnPropertyDescriptor : [Attachment 209058] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 19 02:45:56 PDT 2013


Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 119995: Start removing custom implementations of getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=119995

Attachment 209058: Fix
https://bugs.webkit.org/attachment.cgi?id=209058&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209058&action=review


What remains?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1902
> +	       push(@implContent,
"GET_OWN_PROPERTY_DESCRIPTOR_IMPL(${className})\n");

I think an extra \n at the end would be be nicer.


More information about the webkit-reviews mailing list