[webkit-reviews] review granted: [Bug 120001] Clean up StyleElement : [Attachment 209065] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 19 01:46:23 PDT 2013
Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 120001: Clean up StyleElement
https://bugs.webkit.org/show_bug.cgi?id=120001
Attachment 209065: patch
https://bugs.webkit.org/attachment.cgi?id=209065&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209065&action=review
r=me
(Wow, process -> createSheetFromTextContents.)
> Source/WebCore/dom/StyleElement.cpp:119
> + if (type.isEmpty())
Two spaces!?
> Source/WebCore/dom/StyleElement.cpp:147
> + MediaQueryEvaluator screenEval("screen", true);
> + MediaQueryEvaluator printEval("print", true);
Something, something, ASCIILiteral.
More information about the webkit-reviews
mailing list