[webkit-reviews] review granted: [Bug 119991] change usage of calculateUTCOffset()/calculateDSTOffset to calculateLocalTimeOffset : [Attachment 209052] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 18 23:02:45 PDT 2013


Darin Adler <darin at apple.com> has granted Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 119991: change usage of calculateUTCOffset()/calculateDSTOffset  to
calculateLocalTimeOffset
https://bugs.webkit.org/show_bug.cgi?id=119991

Attachment 209052: Patch
https://bugs.webkit.org/attachment.cgi?id=209052&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209052&action=review


>> Source/WebCore/ChangeLog:7
>> +	    Resolving code error.
> 
> What kind of code error? I don’t understand the reason behind this change. Is
this more elegant? More correct? Both? If more correct, was there a test that
was failing?

Oh, I see, you mean this resolves a build failure? Got it.


More information about the webkit-reviews mailing list