[webkit-reviews] review granted: [Bug 118754] AX: aria-required.html needs to test @required vs @aria-required mismatch reconciliation : [Attachment 209044] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted James Craig <james at cookiecrook.com>'s
request for review:
Bug 118754: AX: aria-required.html needs to test @required vs @aria-required
mismatch reconciliation
https://bugs.webkit.org/show_bug.cgi?id=118754

Attachment 209044: patch
https://bugs.webkit.org/attachment.cgi?id=209044&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209044&action=review


> LayoutTests/accessibility/aria-required-expected.txt:8
> +PASS textfield1 isRequired is false

This is an improvement, but this test is sill deficient. Normally we try to put
as much as possible in the expressions that are logged to make clear what's
being tested, choosing names that express what's going on. The names here do
not make it clear enough what is being tested, so the test output is
sufficiently readable. There is nothing here that helps me understand why
"textfield1" should not be required, but textfield2 should be.