[webkit-reviews] review granted: [Bug 119960] Remove some optimizations made obsolete by use of StringBuilder : [Attachment 209009] pathc

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 119960: Remove some optimizations made obsolete by use of StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=119960

Attachment 209009: pathc
https://bugs.webkit.org/attachment.cgi?id=209009&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209009&action=review


r=me with the cool stories we shared on IRC.

We should clean this up in StyleElement::process(), too.

> Source/WebCore/dom/ScriptElement.cpp:399
> +    for (Text* textNode = TextNodeTraversal::firstChild(m_element);
textNode; textNode = TextNodeTraversal::nextSibling(textNode))
> +	   content.append(textNode->data());

Can't you use TextNodeTraversal::contentsAsString() instead here?