[webkit-reviews] review granted: [Bug 119959] Add TextNodeTraversal : [Attachment 209005] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 119959: Add TextNodeTraversal
https://bugs.webkit.org/show_bug.cgi?id=119959

Attachment 209005: patch
https://bugs.webkit.org/attachment.cgi?id=209005&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209005&action=review


r=me

> Source/WebCore/dom/Text.cpp:139
> +	   resultLength += text->data().length();

text->length() here would avoid some String ref churn.

> Source/WebCore/dom/TextNodeTraversal.h:68
> +    // Except for the root containers, only elements can have element
children.

Copypasta detected.

> Source/WebCore/dom/TextNodeTraversal.h:80
> +    // Except for the root containers, only elements can have element
children.

Copypasta detected.

> Source/WebCore/editing/ApplyStyleCommand.cpp:1525
>      Vector<RefPtr<Text> > textNodes;

Might as well >> this one too. It's so close!