[webkit-reviews] review granted: [Bug 119946] Move some code used only by EventHandler from Clipboard to EventHandler : [Attachment 208995] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 17 07:39:14 PDT 2013


Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 119946: Move some code used only by EventHandler from Clipboard to
EventHandler
https://bugs.webkit.org/show_bug.cgi?id=119946

Attachment 208995: Patch
https://bugs.webkit.org/attachment.cgi?id=208995&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208995&action=review


r=me

> Source/WebCore/page/EventHandler.cpp:2037
> +static inline bool hasFileOfType(Clipboard* clipboard, const String& type)

I'd use Clipboard& here.

> Source/WebCore/page/EventHandler.cpp:2047
> +static inline bool hasStringOfType(Clipboard* clipboard, const String& type)


Ditto.

> Source/WebCore/page/EventHandler.cpp:2052
> +static bool hasDropZoneType(Clipboard* clipboard, const String& keyword)

Ditto.


More information about the webkit-reviews mailing list