[webkit-reviews] review granted: [Bug 119943] Clean up the Document class a bit : [Attachment 208992] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 17 07:21:42 PDT 2013


Antti Koivisto <koivisto at iki.fi> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 119943: Clean up the Document class a bit
https://bugs.webkit.org/show_bug.cgi?id=119943

Attachment 208992: Patch
https://bugs.webkit.org/attachment.cgi?id=208992&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=208992&action=review


> Source/WebCore/dom/Document.cpp:1561
> +	   for (Element* element = headElement->firstElementChild(); element;
element = element->nextElementSibling()) {

The modern way to do this is to use ElementTraversal instead of DOM APIs.


More information about the webkit-reviews mailing list