[webkit-reviews] review denied: [Bug 119932] WebCore fails to build with trunk clang: error: 'register' storage class specifier is deprecated [-Werror, -Wdeprecated-register] : [Attachment 208981] Patch v2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 119932: WebCore fails to build with trunk clang: error: 'register' storage
class specifier is deprecated [-Werror,-Wdeprecated-register]
https://bugs.webkit.org/show_bug.cgi?id=119932

Attachment 208981: Patch v2
https://bugs.webkit.org/attachment.cgi?id=208981&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208981&action=review


> Source/WebCore/css/makeprop.pl:81
> +#if defined(__clang__)
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored \"-Wunknown-pragmas\"
> +#pragma clang diagnostic ignored \"-Wdeprecated-register\"
> +#endif

This is the wrong way to fix it. We should remove the "register" keywords
instead. They are doing no good.