[webkit-reviews] review granted: [Bug 119914] [iOS] Upstream changes to WebCore/accessibility : [Attachment 208961] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Aug 17 05:11:16 PDT 2013
Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 119914: [iOS] Upstream changes to WebCore/accessibility
https://bugs.webkit.org/show_bug.cgi?id=119914
Attachment 208961: Patch
https://bugs.webkit.org/attachment.cgi?id=208961&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208961&action=review
It seems fine to upstream this as-is. We can also later fix the many problems
in this code.
> Source/WebCore/accessibility/AccessibilityObject.cpp:1334
> + DEFINE_STATIC_LOCAL(const String, noAction, ());
> + return noAction;
This should just be:
return nullAtom();
Or maybe:
return nullAtom().string();
No need for this extra local.
> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3177
> + DEFINE_STATIC_LOCAL(const String, noAction, ());
> + return noAction;
This should just be:
return nullAtom();
Or maybe:
return nullAtom().string();
No need for this extra local.
More information about the webkit-reviews
mailing list