[webkit-reviews] review granted: [Bug 119795] Propagate writing-mode from the first region to the flow thread : [Attachment 208951] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Morten Stenshorne
<mstensho at opera.com>'s request for review:
Bug 119795: Propagate writing-mode from the first region to the flow thread
https://bugs.webkit.org/show_bug.cgi?id=119795

Attachment 208951: Patch
https://bugs.webkit.org/attachment.cgi?id=208951&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208951&action=review


> Source/WebCore/rendering/RenderNamedFlowThread.h:71
> +    virtual void regionChangedWritingMode(RenderRegion*) OVERRIDE;

I normally prefer to make overrides like this private since we don’t expect any
non-polymorphic calls to this function, but that’s less important in a class
already marked FINAL where the call will be a normal function call rather than
a virtual dispatch.