[webkit-reviews] review granted: [Bug 119903] Consider making WebCore::Settings ref-counted. : [Attachment 208965] Proposed patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 119903: Consider making WebCore::Settings ref-counted.
https://bugs.webkit.org/show_bug.cgi?id=119903

Attachment 208965: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=208965&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208965&action=review


r=me

> Source/WebCore/html/HTMLEmbedElement.cpp:196
> +    // Workaround for <rdar://problem/6642221>.
> +    if (frame->settings().usesDashboardBackwardCompatibilityMode())
> +	   return true;

My favorite of all the settings.

> Source/WebCore/page/Frame.h:144
> +	   Settings& settings() const { return *m_settings; }

Should this be const Settings&? I don't think any clients want the ability to
change the settings inside WebCore.