[webkit-reviews] review granted: [Bug 119282] revalidateTiles and ensureTilesForRect can share a lot of code : [Attachment 208872] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 16 17:33:17 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 119282: revalidateTiles and ensureTilesForRect can share a lot of code
https://bugs.webkit.org/show_bug.cgi?id=119282

Attachment 208872: patch
https://bugs.webkit.org/attachment.cgi?id=208872&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208872&action=review


> Source/WebCore/platform/graphics/ca/mac/TileController.h:149
> +    enum class NewTileType { PrimaryTiles, SecondaryTiles };

Maybe CoverageType?

> Source/WebCore/platform/graphics/ca/mac/TileController.h:150
> +    IntRect ensureTilesForRect(const FloatRect&, NewTileType);

What does the return value mean?


More information about the webkit-reviews mailing list