[webkit-reviews] review granted: [Bug 119910] [Windows] Update RenderMediaControls for new API : [Attachment 208955] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 119910: [Windows] Update RenderMediaControls for new API
https://bugs.webkit.org/show_bug.cgi?id=119910

Attachment 208955: Patch
https://bugs.webkit.org/attachment.cgi?id=208955&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208955&action=review


> Source/WebCore/rendering/RenderMediaControls.cpp:57
> +#if HAVE(AVCF_LEGIBLE_OUTPUT) // i.e., the new media controls
> +#define wkHitTestMediaUIPart(part, bounds, point) WKHitTestMediaUIPart(part,
bounds, point)
> +#define wkMeasureMediaUIPart(part, bounds, naturalSize)
WKMeasureMediaUIPart(part, bounds, naturalSize)
> +#define wkDrawMediaUIPart(part, context, rect, state)
WKDrawMediaUIPart(part, context, rect, state)
> +#define wkDrawMediaSliderTrack(context, rect, timeLoaded, currentTime,
duration, state) WKDrawMediaSliderTrack(context, rect, timeLoaded, currentTime,
duration, state)
> +#else
> +// This is needed until WebKitSystemInterface is updated on the build
machines
> +#define wkHitTestMediaUIPart(part, bounds, point) WKHitTestMediaUIPart(part,
WKMediaControllerThemeQuickTime, bounds, point)
> +#define wkMeasureMediaUIPart(part, bounds, naturalSize)
WKMeasureMediaUIPart(part, WKMediaControllerThemeQuickTime, bounds,
naturalSize)
> +#define wkDrawMediaUIPart(part, context, rect, state)
WKDrawMediaUIPart(part, WKMediaControllerThemeQuickTime, context, rect, state)
> +#define wkDrawMediaSliderTrack(context, rect, timeLoaded, currentTime,
duration, state) WKDrawMediaSliderTrack(WKMediaControllerThemeQuickTime,
context, rect, timeLoaded, currentTime, duration, state)
> +#endif

This might be slightly cleaner as inline functions instead of #defines.