[webkit-reviews] review granted: [Bug 119795] Propagate writing-mode from the first region to the flow thread : [Attachment 208920] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Morten Stenshorne
<mstensho at opera.com>'s request for review:
Bug 119795: Propagate writing-mode from the first region to the flow thread
https://bugs.webkit.org/show_bug.cgi?id=119795

Attachment 208920: Patch
https://bugs.webkit.org/attachment.cgi?id=208920&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208920&action=review


> Source/WebCore/ChangeLog:1
> +2013-08-14  mstensho at opera.com  <mstensho at opera.com>

This should have your real name rather having than your email address twice.

> Source/WebCore/rendering/RenderNamedFlowThread.cpp:95
> +    if (RenderRegion* firstRegion = m_regionList.first()) {
> +	   if (style()->writingMode() != firstRegion->style()->writingMode()) {


We normally prefer to use early return rather than nesting the whole function
inside an if statement.

> Source/WebCore/rendering/RenderNamedFlowThread.cpp:99
> +	       setStyle(newStyle);

This should be:

    setStyle(newStyle.release());