[webkit-reviews] review granted: [Bug 119583] [Win] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT : [Attachment 208931] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 119583: [Win] URL printing code in DumpRenderTree doesn't match WTR or Mac
DRT
https://bugs.webkit.org/show_bug.cgi?id=119583

Attachment 208931: Patch
https://bugs.webkit.org/attachment.cgi?id=208931&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208931&action=review


Great, thank you for tackling this!

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:144
> +static wstring fallbackString(CFURLRef url)

I'd name this function after what it does - in this case, it seems more
straightforward than naming it by what it is used for. What about
lastPathComponent() as the name?