[webkit-reviews] review granted: [Bug 118105] Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs : [Attachment 208883] patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted James Craig
<james at cookiecrook.com>'s request for review:
Bug 118105: Web Inspector: AX: Add support for ARIA tablists/tabs to inspector
tabs
https://bugs.webkit.org/show_bug.cgi?id=118105

Attachment 208883: patch
https://bugs.webkit.org/attachment.cgi?id=208883&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208883&action=review


r=me

> Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:33
> +

Style: Remove this extra blank line.

> Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:64
> +	       if (this._role == "tab")

Style: In Web Inspector we use strict equality `===` whenever possible.

> Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:69
> +	       if (this._role == "tab")

===

> Source/WebInspectorUI/UserInterface/Toolbar.js:38
> +    this._leftSectionElement.setAttribute('role', 'tablist');

Style: In Web Inspector we use double quoted strings whenever possible. "role"
/ "tablist".

> Source/WebInspectorUI/UserInterface/Toolbar.js:47
> +    this._rightSectionElement.setAttribute('role', 'tablist');

"…"