[webkit-reviews] review denied: [Bug 119583] [Win] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT : [Attachment 208929] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 119583: [Win] URL printing code in DumpRenderTree doesn't match WTR or Mac
DRT
https://bugs.webkit.org/show_bug.cgi?id=119583

Attachment 208929: Patch
https://bugs.webkit.org/attachment.cgi?id=208929&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208929&action=review


There are more instances of "return urlString;" above the changed code, all
except the very first one should be changed to return the last path component.
We never want a full file:// path!

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:172
> +    if (path.get() && CFStringHasPrefix(path.get(), basePath.get()))

This null check should be for basePath, not for path.