[webkit-reviews] review granted: [Bug 119887] [Soup] The testing NetworkStorageSession should have a proper SoupSession : [Attachment 208901] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 16 07:14:06 PDT 2013


Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 119887: [Soup] The testing NetworkStorageSession should have a proper
SoupSession
https://bugs.webkit.org/show_bug.cgi?id=119887

Attachment 208901: Patch
https://bugs.webkit.org/attachment.cgi?id=208901&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208901&action=review


Does this cause any new tests to pass or does it fix some tests that are
failing?

> Source/WebCore/ChangeLog:3
> +	   <https://webkit.org/b/119887> [Soup] The testing
NetworkStorageSession should have a proper SoupSession

The description field is a little funky.

> Source/WebCore/ChangeLog:11
> +	   NetworkStorageSession, which ends up being null if the
testing-specific NetworkStorageSession is sued.

s/sued/used


More information about the webkit-reviews mailing list