[webkit-reviews] review granted: [Bug 119493] (NetworkProcess) Sync XHRs should load using async ResourceHandles, not ResourceHandle::loadResourceSynchronously : [Attachment 208837] Patch v2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 119493: (NetworkProcess)  Sync XHRs should load using async
ResourceHandles, not ResourceHandle::loadResourceSynchronously
https://bugs.webkit.org/show_bug.cgi?id=119493

Attachment 208837: Patch v2
https://bugs.webkit.org/attachment.cgi?id=208837&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me with changes made during in person discussion, plus not skipping the
tests, and with changes suggested in prior review, and assuming all tests pass.


> - simple-cross-origin-denied-events tests;

This was an actual bug, and the fix appears to be to delete obsolete code that
synthesizes an HTTP response for 401 authentication failures (and also
synthesizes more response types just for good measure that turned bad).

It wasn't actually that we got to CORS checks due to different ordering, but
that NetworkProcess was sending a bad response/error pair that confused
WebProcess.

> - what platformBadSynchronousXHRResponseError means;

Brady will just rename it back, we don't feel like thinking about this too much
now.

> - is there anything suspicious with 6+1 handling.

Brady says that it works the same as before.