[webkit-reviews] review granted: [Bug 119869] [Windows] Consolidate WebKit Bundle handling : [Attachment 208863] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 119869: [Windows] Consolidate WebKit Bundle handling
https://bugs.webkit.org/show_bug.cgi?id=119869

Attachment 208863: Patch
https://bugs.webkit.org/attachment.cgi?id=208863&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208863&action=review


> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:7069
> +    <ClCompile Include="..\css\CSSFilterImageValue.cpp" />

I think these are unrelated, but maybe expected automatic VS changes?

> Source/WebCore/platform/win/WebCoreBundleWin.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

The license from the old file should carry over (so this should be '2011,
2013').

> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:161
> +    RetainPtr<CFURLRef> htmlURLRef =
adoptCF(CFBundleCopyResourceURL(WebCore::webKitBundle(), CFSTR("inspector"),
CFSTR("html"), CFSTR("inspector")));

why do you need the explicit namespace? This file 'using namespace WebCore's.