[webkit-reviews] review denied: [Bug 119863] [iOS] Upstream WebCore/editing/ios : [Attachment 208855] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied  review:
Bug 119863: [iOS] Upstream WebCore/editing/ios
https://bugs.webkit.org/show_bug.cgi?id=119863

Attachment 208855: Patch
https://bugs.webkit.org/attachment.cgi?id=208855&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208855&action=review


> Source/WebCore/WebCore.xcodeproj/project.pbxproj:5239
> +		CE13CA9517BD7DB3001CF3BE /* EditorIOS.mm in Sources */ = {isa =
PBXBuildFile; fileRef = CE13CA9417BD7DB3001CF3BE /* EditorIOS.mm */; };

Please use the UUIDs from the iOS tree.  It will make merging much simpler
later.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:12010
> +		CE13CA9417BD7DB3001CF3BE /* EditorIOS.mm */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp;
path = EditorIOS.mm; sourceTree = "<group>"; };

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:15513
> +				CE13CA9317BD7DB3001CF3BE /* ios */,

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:19496
> +		CE13CA9317BD7DB3001CF3BE /* ios */ = {
> +			isa = PBXGroup;
> +			children = (
> +				CE13CA9417BD7DB3001CF3BE /* EditorIOS.mm */,
> +			);
> +			path = ios;
> +			sourceTree = "<group>";
> +		};

Ditto.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:24999
> +				CE13CA9517BD7DB3001CF3BE /* EditorIOS.mm in
Sources */,

Ditto.