[webkit-reviews] review granted: [Bug 119843] PropertySlot::setValue is ambiguous : [Attachment 208811] fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 119843: PropertySlot::setValue is ambiguous
https://bugs.webkit.org/show_bug.cgi?id=119843

Attachment 208811: fix
https://bugs.webkit.org/attachment.cgi?id=208811&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208811&action=review


> Source/JavaScriptCore/runtime/PropertySlot.h:104
> +    void setValue(JSString*, JSValue value)

This would be a good place for a piece of your ChangeLog comment: Logically,
the base of a string property access is a temporary StringObject, but we
optimize that away.