[webkit-reviews] review granted: [Bug 118532] [Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont : [Attachment 208619] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 118532: [Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont
https://bugs.webkit.org/show_bug.cgi?id=118532

Attachment 208619: Patch
https://bugs.webkit.org/attachment.cgi?id=208619&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208619&action=review


> Source/WebCore/ChangeLog:8
> +	   Allocate FontPlatformData on the stack instead on the heap.

A note that getCachedFontData does a deep copy of FontPlatformData could be
useful to explain why this change is necessary.