[webkit-reviews] review requested: [Bug 115352] [gstreamer] Make sure gstreamer source element is thread-safe : [Attachment 208788] Updated patch against upstream master

[bugzilla-daemon at webkit.org]

Andre Moreira Magalhaes <andrunko at gmail.com> has asked	for review:
Bug 115352: [gstreamer] Make sure gstreamer source element is thread-safe
https://bugs.webkit.org/show_bug.cgi?id=115352

Attachment 208788: Updated patch against upstream master
https://bugs.webkit.org/attachment.cgi?id=208788&action=review

------- Additional Comments from Andre Moreira Magalhaes <andrunko at gmail.com>
This patch should fix the regressions with bug #117141 and bug #117688 by
removing the timeout sources (e.g. scheduled start) when state changes to NULL
as stop is scheduled to run only on mainloop. It should also fix another issue
where the player was being reset on seek.

As discussed on IRC this patch introduces 2 separate code branches, one where
the player is available and using CachedResourceLoader and another one where
there is no player involved using a ResourceHandle.

I ran some tests with and without this patch and couldn't find any regression.
I also tested the patch with a series of videos (including DASH that requires a
new gst version) and everything seems to be working fine. Please let me know
what you think.

Also see comments on bug #73743 and bug #108088.