[webkit-reviews] review denied: [Bug 119812] errorDescriptionForValue() should not assume error value is an Object : [Attachment 208776] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Chris Curtis
<chris_curtis at apple.com>'s request for review:
Bug 119812: errorDescriptionForValue() should not assume error value is an
Object
https://bugs.webkit.org/show_bug.cgi?id=119812

Attachment 208776: patch
https://bugs.webkit.org/attachment.cgi?id=208776&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208776&action=review


We need a regression test for this. Or an explanation of why you can’t make
one.

> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:109
> +	   return jsString(exec,
asObject(v)->methodTable()->className(asObject(v)));

Should use “object” here instead of “asObject(v)”.

> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:111
> +    return jsString(exec, "");

Should be:

    return vm->smallStrings.emptyString();

But why specifically the empty string?