[webkit-reviews] review granted: [Bug 119810] [Mac] No AutoreleasePool leaks when dragging image out of WebView : [Attachment 208768] [PATCH] Proposed fix - convert pthread to dispatch block

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 14 16:27:14 PDT 2013


mitz at webkit.org <mitz at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 119810: [Mac] No AutoreleasePool leaks when dragging image out of WebView
https://bugs.webkit.org/show_bug.cgi?id=119810

Attachment 208768: [PATCH] Proposed fix - convert pthread to dispatch block
https://bugs.webkit.org/attachment.cgi?id=208768&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208768&action=review


> Source/WebCore/platform/mac/FileSystemMac.mm:81
> +	   wkSetMetadataURL(URLStringCopy, referrerCopy, (NSString
*)String::fromUTF8(fileSystemRepresentation(pathCopy).data()));

You should just use -[NSString fileSystemRepresentation].


More information about the webkit-reviews mailing list