[webkit-reviews] review granted: [Bug 119817] AX: Integrate layout tests from overflow bounding boxes are way too big; prevents VoiceOver taps from activating the right elements : [Attachment 208761] patch

Wed Aug 14 15:39:59 PDT 2013

Simon Fraser (smfr) <simon.fraser at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 119817: AX: Integrate layout tests from overflow bounding boxes are way too
big; prevents VoiceOver taps from activating the right elements
https://bugs.webkit.org/show_bug.cgi?id=119817

Attachment 208761: patch
https://bugs.webkit.org/attachment.cgi?id=208761&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208761&action=review

> LayoutTests/accessibility/transformed-bounds.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

<!DOCTYPE html> will do

> LayoutTests/accessibility/transformed-bounds.html:15
> +	   
> +	   .pills
.button{-webkit-appearance:none;display:inline-block;vertical-align:top;text-al
ign:center;width:100%}
> +	   .pills
.label{display:block;font-weight:bold;white-space:nowrap;text-overflow:ellipsis
;overflow:hidden}
> +	   .ipad .top-section{text-align:center}
> +	   .pills{display:inline-block;height:29px;margin:0 auto 10px;padding:0
15px;min-width:292px}
> +	   .pills div{display:inline-block;text-align:center}
> +	   .swoosh-overlay .contents .row .item:not(.software)
.card-container{-webkit-transform-origin-x:315px}
> +	   .swoosh-overlay .contents .row .item
.card-container{-webkit-transform-style:preserve-3d;position:absolute}
> +	   .swoosh-overlay .item
.card-back{position:absolute;z-index:200;width:630px;height:630px;-webkit-backf
ace-visibility:hidden;-webkit-transform:rotatey(180deg)}

Please expand these. I doubt that all the styles are necessary for the
testcase; can you simplify this more?