[webkit-reviews] review granted: [Bug 119748] ASSERTION FAILED: resultAnimationElement->m_animatedType in WebCore::SVGAnimateElement::calculateAnimatedValue : [Attachment 208726] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 119748: ASSERTION FAILED: resultAnimationElement->m_animatedType in
WebCore::SVGAnimateElement::calculateAnimatedValue
https://bugs.webkit.org/show_bug.cgi?id=119748

Attachment 208726: Patch
https://bugs.webkit.org/attachment.cgi?id=208726&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208726&action=review


r=me

> Source/WebCore/svg/SVGAnimateTransformElement.cpp:53
> +    if (attributeType() == AttributeTypeCSS)
> +	   return false;

We discussed it on IRC before and came to the conclusion that this is the
better solution for now. We may do not even want to support CSS Transforms in
animateTransform in the future.