[webkit-reviews] review granted: [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain : [Attachment 208709] patch v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 14 03:39:08 PDT 2013


Christophe Dumez <dchris at gmail.com> has granted Peter Gal
<galpeter at inf.u-szeged.hu>'s request for review:
Bug 118306: [WTR] Should dump as text when the mimetype is text/plain
https://bugs.webkit.org/show_bug.cgi?id=118306

Attachment 208709: patch v5
https://bugs.webkit.org/attachment.cgi?id=208709&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208709&action=review


Looks fine. r=me with nits.

> LayoutTests/ChangeLog:9
> +	   Now the result should match the expected.

expected -> "expectation"

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:853
> +    WKRetainPtr<WKStringRef> mimeType=
adoptWK(WKBundleFrameCopyMIMETypeForResourceWithURL(frame, urlRef.get()));

nit: missing space before equal


More information about the webkit-reviews mailing list