[webkit-reviews] review requested: [Bug 119790] [Qt] Activate visibility API layout tests : [Attachment 208711] Implement the needed API and remove Page Visibility API test from Qt TestExpectations file.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 14 03:26:52 PDT 2013


Benjamin Dupont <bdupont at nds.com> has asked  for review:
Bug 119790: [Qt] Activate visibility API layout tests
https://bugs.webkit.org/show_bug.cgi?id=119790

Attachment 208711: Implement the needed API and remove Page Visibility API test
from Qt TestExpectations file.
https://bugs.webkit.org/attachment.cgi?id=208711&action=review

------- Additional Comments from Benjamin Dupont <bdupont at nds.com>
Tests results:
fast/events/page-visibility-iframe-delete-test.html:
This test checks that the page visibility event propagation does not crash the
browser when frames are added / deleted.

On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".


Loaded all frames.
Visibility of main document changed.
Visibility of sub frame 2 changed.
PASS successfullyParsed is true

TEST COMPLETE


fast/events/page-visibility-iframe-move-test.html:
Content-Type: text/plain
This test checks that an iframe that moves between pages with different
visibility will have the correct visibility value.

On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".


Window 1 Loaded
Window 2 Loaded
PASS window.document.hidden is false
PASS window2.document.hidden is false
PASS iframe.contentDocument.hidden is false
PASS window.document.hidden is true
PASS window2.document.hidden is false
PASS iframe.contentDocument.hidden is false
Adopted iframe to Window 1
PASS window.document.hidden is true
PASS window2.document.hidden is false
PASS iframe.contentDocument.hidden is true
PASS successfullyParsed is true

TEST COMPLETE


fast/events/page-visibility-iframe-propagation-test.html:
This test checks that Page Visibility state events are propagated to child
frames.

On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".


Main Page:
PASS document.visibilityState is "visible"
PASS document.hidden is false
Child Frame:
PASS childFrame.contentDocument.visibilityState is "visible"
PASS childFrame.contentDocument.hidden is false
Main Page:
PASS document.visibilityState is "hidden"
PASS document.hidden is true
Child Frame:
PASS childFrame.contentDocument.visibilityState is "hidden"
PASS childFrame.contentDocument.hidden is true
Main Page:
PASS document.visibilityState is "visible"
PASS document.hidden is false
Child Frame:
PASS childFrame.contentDocument.visibilityState is "visible"
PASS childFrame.contentDocument.hidden is false
PASS successfullyParsed is true

TEST COMPLETE


fast/events/page-visibility-null-view.html:
This test checks that Page Visibility state values are correct when a document
has no defaultView.

On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".


PASS subdocument.defaultView == null is true
PASS subdocument.visibilityState is "hidden"
PASS subdocument.hidden is true
PASS successfullyParsed is true

TEST COMPLETE


fast/events/page-visibility-transition-test.html:
This test checks that Page Visibility state values are correct and the event
changes are fired correctly.

On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".


PASS document.visibilityState is "visible"
PASS document.hidden is false
PASS document.visibilityState is "hidden"
PASS document.hidden is true
PASS document.visibilityState is "hidden"
PASS document.hidden is true
PASS document.visibilityState is "prerender"
PASS document.hidden is true
PASS document.visibilityState is "visible"
PASS document.hidden is false
PASS document.visibilityState is "unloaded"
PASS document.hidden is true
PASS document.visibilityState is "visible"
PASS document.hidden is false
PASS successfullyParsed is true

TEST COMPLETE


fast/frames/page-visibility-crash.html:
PASS. WebKit didn't crash


More information about the webkit-reviews mailing list