[webkit-reviews] review granted: [Bug 119778] Add Canvas protocol observer : [Attachment 208693] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 119778: Add Canvas protocol observer
https://bugs.webkit.org/show_bug.cgi?id=119778

Attachment 208693: Patch
https://bugs.webkit.org/attachment.cgi?id=208693&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208693&action=review


r=me, with 1 comment

> Source/WebInspectorUI/UserInterface/Main.js:41
> +    InspectorBackend.registerCanvasDispatcher(new
WebInspector.CanvasObserver);

InspectorBackend.registerCanvasDispatcher did not exist in iOS 6.

iOS 6 devices load the UserInterface/Legacy/6.0/InspectorBackendCommands.js
file instead of the UserInterface/InspectorBackendCommands.js in
LoadInspectorBackendCommands.js. So the lack of that function existing will
mean that this would be an uncaught exception.

You should do this at the bottom like the LayerTreeDispatcher.

    if (InspectorBackend.registerCanvasDispatcher)
	InspectorBackend.registerCanvasDispatcher(new
WebInspector.CanvasObserver);