[webkit-reviews] review granted: [Bug 116412] [iOS] Get iOS port off legacy clipboard : [Attachment 208640] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 116412: [iOS] Get iOS port off legacy clipboard
https://bugs.webkit.org/show_bug.cgi?id=116412

Attachment 208640: Patch
https://bugs.webkit.org/attachment.cgi?id=208640&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208640&action=review


This change looks sane to me. I noticed some minor issues. I am happy to help
you merge this change into iOS WebKit and test it. We will likely need to make
changes to iOS-specific files that aren't upstream, at the time of writing,
before we can build with this change. It should be sufficient to land this
change and then merge it into iOS WebKit and test it. Let me know if you would
like to make such changes and test this patch before landing it in the
WebKit.org repository.

Dave Kilzer may also have insight/suggestions into how best to merge and test
this in iOS WebKit.

> Source/WebCore/editing/Editor.cpp:712
> +    clipboard->pasteboard()->setFrame(m_frame);

Notice that Clipboard::pasteboard() returns a reference instead of a pointer:
<http://trac.webkit.org/browser/trunk/Source/WebCore/dom/Clipboard.h?rev=153978
#L136>. So, we need to write this as:

clipboard->pasteboard().setFrame(m_frame);

> Source/WebCore/platform/ios/PasteboardIOS.mm:514
> +String Pasteboard::readString(const String& type) const

Notice that Pasteboard::readString() isn't declared const in Pasteboard.h,
<http://trac.webkit.org/browser/trunk/Source/WebCore/platform/Pasteboard.h#L129
>.

> Source/WebCore/platform/ios/PasteboardIOS.mm:605
> +ListHashSet<String> Pasteboard::types() const

Notice that Pasteboard::types() isn't declared const in Pasteboard.h,
<http://trac.webkit.org/browser/trunk/Source/WebCore/platform/Pasteboard.h?rev=
153978#L127>.