[webkit-reviews] review granted: [Bug 119709]=?UTF-8?Q?=20Remotely=20hosted=20plugins=20don=E2=80=99t=20work=20in=20window=2Dserver=2Dhosted=20WebKit1=20views=20?=: [Attachment 208667] patch with dynamic updating

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 119709: Remotely hosted plugins don’t work in window-server-hosted WebKit1
views
https://bugs.webkit.org/show_bug.cgi?id=119709

Attachment 208667: patch with dynamic updating
https://bugs.webkit.org/attachment.cgi?id=208667&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208667&action=review


> Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:259
> +    BOOL shouldHostLayersInWindowServer = [self
windowHostsLayersInWindowServer];

I think you should declare this as bool instead.

> Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:260
> +    if (_hostsLayersInWindowServer != shouldHostLayersInWindowServer)

Otherwise this might not do what you want it to.