[webkit-reviews] review granted: [Bug 90341] createAttribute/setAttributeNode does not properly normalize case : [Attachment 208627] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 90341: createAttribute/setAttributeNode does not properly normalize case
https://bugs.webkit.org/show_bug.cgi?id=90341

Attachment 208627: Patch
https://bugs.webkit.org/attachment.cgi?id=208627&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208627&action=review


> Source/WebCore/dom/QualifiedName.h:84
> +    bool matchesIgnoringCaseForLocalName(const QualifiedName& other, bool
shouldIgnoreCase = false) const { return m_impl == other.m_impl ||
(equalPossiblyIgnoringCase(localName(), other.localName(), shouldIgnoreCase) &&
namespaceURI() == other.namespaceURI()); }

There is no reason for the shouldIgnoreCase function to have a default of
false. When the value is false, it's just a slower version of the matches
function, so we would not want anyone to call it in that case.