[webkit-reviews] review denied: [Bug 90341] createAttribute/setAttributeNode does not properly normalize case : [Attachment 208520] Patch

Mon Aug 12 22:07:08 PDT 2013

Ryosuke Niwa <rniwa at webkit.org> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 90341: createAttribute/setAttributeNode does not properly normalize case
https://bugs.webkit.org/show_bug.cgi?id=90341

Attachment 208520: Patch
https://bugs.webkit.org/attachment.cgi?id=208520&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208520&action=review

> Source/WebCore/dom/Element.cpp:3243
> -	   if (attributes[i].name() == attr->qualifiedName())
> +	   if
(attributes[i].name().matchesIgnoringCaseForLocalName(attr->qualifiedName(),
shouldIgnoreAttributeCase))

On my second thought, this is incorrect. One one hand, createElement('STYLE')
in a HTML document will create an attribute with localName of 'style', NOT
'STYLE'.  On the other hand, 'STYLE' attribute is NOT equal to 'style'
attribute in a XHTML document.
Furthermore, XHTML documents differentiates each attribute in case sensitive
matter so there is no way this code is correct at least for XHTML document.
r-.

> LayoutTests/fast/dom/Element/setAttributeNode-case-insensitivity.html:1
> +<html>

Missing DOCTYPE.