[webkit-reviews] review granted: [Bug 119701] Encapsulate access to documentNamedItemMap and windowNamedItemMap : [Attachment 208569] Cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 12 16:20:07 PDT 2013


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 119701: Encapsulate access to documentNamedItemMap and windowNamedItemMap
https://bugs.webkit.org/show_bug.cgi?id=119701

Attachment 208569: Cleanup
https://bugs.webkit.org/attachment.cgi?id=208569&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The need to not call these functions with a null string is less obvious when
calling through these new functions than it was when dealing with the map
directly; it’s easy to get that wrong at call sites. I worry a little about
that.


More information about the webkit-reviews mailing list