[webkit-reviews] review granted: [Bug 119700] Use const AtomicStringImpl* in DocumentOrderedMap : [Attachment 208565] Cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 12 14:47:22 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 119700: Use const AtomicStringImpl* in DocumentOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=119700

Attachment 208565: Cleanup
https://bugs.webkit.org/attachment.cgi?id=208565&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208565&action=review


> Source/WebCore/ChangeLog:9
> +	   Use const AtomicStringImpl* in DocumentOrderedMap. It caught at
least one bug that HTMLNameCollection'
> +	   subclasses' nodeMatches were taking const AtomicString& instead of
AtomicStringImpl*.

I think you should detail this a little more.


More information about the webkit-reviews mailing list