[webkit-reviews] review granted: [Bug 119272] Broken build with build-webkit --no-webgl : [Attachment 208539] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 12 11:10:02 PDT 2013


Alexandru Chiculita <achicu at adobe.com> has granted Ragner Magalhaes
<ragner.magalhaes at gmail.com>'s request for review:
Bug 119272: Broken build with build-webkit --no-webgl
https://bugs.webkit.org/show_bug.cgi?id=119272

Attachment 208539: Patch
https://bugs.webkit.org/attachment.cgi?id=208539&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review


>> Source/WTF/ChangeLog:8
>> +	    CSS_SHADERS requires WEBGL enabled.
> 
> Is not it more accurate to say that it requeres ANGLE, which is only
available when WebGL is on?

Custom Filters are implemented on top of WebGL. We are only using ANGLE to
validate the shaders, so we need both.


More information about the webkit-reviews mailing list