[webkit-reviews] review granted: [Bug 116715] ASSERTION FAILED: type() == Percent in WebCore::Length::percent : [Attachment 208546] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 12 09:59:33 PDT 2013


Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 116715: ASSERTION FAILED: type() == Percent in WebCore::Length::percent
https://bugs.webkit.org/show_bug.cgi?id=116715

Attachment 208546: Patch
https://bugs.webkit.org/attachment.cgi?id=208546&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208546&action=review


> Source/WebCore/platform/Length.h:139
> +	   ASSERT(type() == Percent || type() == Calculated);

I think it would be clearer to do:

    ASSERT(isPercent());


More information about the webkit-reviews mailing list