[webkit-reviews] review granted: [Bug 119658] Remove didNewFirstVisuallyNonEmptyLayout from WebKit2 : [Attachment 208486] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 119658: Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=119658

Attachment 208486: Patch
https://bugs.webkit.org/attachment.cgi?id=208486&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208486&action=review


> Source/WebKit2/UIProcess/WebLoaderClient.h:66
> +    // FIXME: We should consider removing
didFirstVisuallyNonEmptyLayoutForFrame since its functionality is replaced by
didLayout.

I would like a shorter comment. I’m not sure the word “functionality” adds
anything here.

    // FIXME: Remove didFirstVisuallyNonEmptyLayoutForFrame; clients should use
didLayout instead.