[webkit-reviews] review granted: [Bug 119620] [Curl] Crash when starting second download. : [Attachment 208419] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted peavo at outlook.com's request for
review:
Bug 119620: [Curl] Crash when starting second download.
https://bugs.webkit.org/show_bug.cgi?id=119620

Attachment 208419: Patch
https://bugs.webkit.org/attachment.cgi?id=208419&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208419&action=review


r=me

> Source/WebCore/platform/network/curl/CurlDownload.cpp:133
> +	   if (addToCurl(m_pendingHandleList[0]))

I know you only moved this code, but glancing at it I am concerned by this
loop. It seems like we could get stuck here if the 'addToCurl' keeps failing
for the 0th entry in the pending handle list. Could you look over addToCurl at
some point and see if this might be an issue?