[webkit-reviews] review granted: [Bug 119677] Page::mainFrame() should return a reference. : [Attachment 208535] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 119677: Page::mainFrame() should return a reference.
https://bugs.webkit.org/show_bug.cgi?id=119677

Attachment 208535: Patch
https://bugs.webkit.org/attachment.cgi?id=208535&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=208535&action=review


rs=me

> Source/WebCore/ChangeLog:11
> +	   In practice, Page always has a mainFrame(). There's a short window
in time
> +	   between construction and Frame::create() calling
Page::setMainFrame() where
> +	   m_page is null, but mainFrame() should not be used then. We guard
against
> +	   this with an assertion in mainFrame().

Would be nice to cleanup this awkward construction pattern.