[webkit-reviews] review granted: [Bug 119676] Move some Document recalcStyle code to StyleResolveTree : [Attachment 208524] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 12 03:19:53 PDT 2013


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 119676: Move some Document recalcStyle code to StyleResolveTree
https://bugs.webkit.org/show_bug.cgi?id=119676

Attachment 208524: patch
https://bugs.webkit.org/attachment.cgi?id=208524&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208524&action=review


r=me

> Source/WebCore/style/StyleResolveTree.cpp:299
> +    for (Node* child = document->firstChild(); child; child =
child->nextSibling()) {
> +	   if (!child->isElementNode())
> +	       continue;
> +	   Element* elementChild = toElement(child);

We should make ElementTraversal support this case.


More information about the webkit-reviews mailing list