[webkit-reviews] review denied: [Bug 119536] Refactor highestEditableRoot to avoid a redundant call to rendererIsEditable : [Attachment 208236] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Vani Hegde
<vani.hegde at samsung.com>'s request for review:
Bug 119536: Refactor highestEditableRoot to avoid a redundant call to
rendererIsEditable
https://bugs.webkit.org/show_bug.cgi?id=119536

Attachment 208236: Patch
https://bugs.webkit.org/attachment.cgi?id=208236&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208236&action=review


> Source/WebCore/editing/htmlediting.cpp:123
> +    if (highestRoot->hasTagName(bodyTag))
> +	   return highestRoot;
> +
> +    node = highestRoot->parentNode();

Please don't repeat the code. We can rearrange the code inside the loop
instead.