[webkit-reviews] review granted: [Bug 119651] [GObject] Wrap KeyboardEvent : [Attachment 208471] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 119651: [GObject] Wrap KeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=119651

Attachment 208471: Patch
https://bugs.webkit.org/attachment.cgi?id=208471&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208471&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:114
> +    return "Event" if $parent eq "UIEvent" or $parent eq "MouseEvent" or
$parent eq "KeyboardEvent";

Could we simply use $codeGenerator->InheritsInterface("Event") ? This does not
look very scalable.