[webkit-reviews] review denied: [Bug 119454] Next layout after frameview load is completed should update scrollbars if necessary : [Attachment 208456] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 9 16:35:00 PDT 2013


Beth Dakin <bdakin at apple.com> has denied Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 119454: Next layout after frameview load is completed should update
scrollbars if necessary
https://bugs.webkit.org/show_bug.cgi?id=119454

Attachment 208456: patch
https://bugs.webkit.org/attachment.cgi?id=208456&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208456&action=review


r- because you are not initializing m_scrollbarUpdatePending in the FrameView
constructor, but I think this is okay otherwise. So this is close!

> Source/WebCore/page/FrameView.cpp:1295
> +		       

You should remove this new whitespace.


More information about the webkit-reviews mailing list